Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate & de-conflict Black's target version #707

Merged
merged 2 commits into from
Dec 26, 2023
Merged

De-duplicate & de-conflict Black's target version #707

merged 2 commits into from
Dec 26, 2023
+1 −2

Conversation

hynek
Copy link
Member

@hynek hynek commented Dec 20, 2023

Y'all should also consider switching away from setup.py, because Black will happily parse pyproject.toml's python-version avoiding this whole problem in the first place.

@hynek hynek requested a review from a team as a code owner December 20, 2023 06:05
adiroiban
adiroiban approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Loogs good to merge.

@glyph glyph enabled auto-merge December 26, 2023 04:04
@glyph glyph merged commit 1ee8f76 into trunk Dec 26, 2023
25 checks passed
@glyph glyph deleted the black-target branch December 26, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hynek @adiroiban @glyph